pingu_98/MrDraw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

code cleanup

Browse source
This commit is contained in:
Teja 2015-01-28 18:34:17 +01:00
parent 61033fe7e5
commit 336076f254
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/octoprint/plugins/svgtogcode/static/js/convert.js
View file

@ -24,10 +24,6 @@ function VectorConversionViewModel(params) {
self.profile = ko.observable();
self.profiles = ko.observableArray();
self.laserIntensity.subscribe(function(newVal){
console.log("laserInt new Val", newVal);
});
// TODO check if still in use
self.show = function(target, file) {
self.target = target;
@ -88,7 +84,6 @@ function VectorConversionViewModel(params) {
self.profilesForSlicer(newValue);
});
// TODO check if still necessary...
self.enableConvertButton = ko.computed(function() {
if (self.laserIntensity() === undefined || self.laserSpeed() === undefined || self.gcodeFilename() === undefined) {
return false;
@ -97,7 +92,7 @@ function VectorConversionViewModel(params) {
var tmpSpeed = self.laserSpeed();
var tmpGcodeFilename = self.gcodeFilename().trim();
return tmpGcodeFilename !== ""
&& tmpIntensity > 0 && tmpIntensity <= 1000
&& tmpIntensity > 0 && tmpIntensity <= 1000 // TODO no magic numbers here!
&& tmpSpeed >= 30 && tmpSpeed <= 3000;
}
});
@ -247,8 +242,8 @@ function VectorConversionViewModel(params) {
reversed: false,
selection: "after",
orientation: "horizontal",
min: 20,
max: 3000,
min: 30,
max: 3000, // TODO no magic numbers here.
step: 10,
value: 300,
enabled: true,