From 62aee507013939cbf82d835923e72ca09d188941 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gina=20H=C3=A4u=C3=9Fge?= <osd@foosel.net>
Date: Thu, 9 Jul 2015 15:43:11 +0200
Subject: [PATCH] rel="noopener noreferrer" for external links

---
 .../pluginmanager/templates/pluginmanager_settings.jinja2 | 2 +-
 .../softwareupdate/templates/softwareupdate.jinja2        | 2 +-
 .../templates/softwareupdate_settings.jinja2              | 2 +-
 src/octoprint/templates/index.jinja2                      | 8 ++++----
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/octoprint/plugins/pluginmanager/templates/pluginmanager_settings.jinja2 b/src/octoprint/plugins/pluginmanager/templates/pluginmanager_settings.jinja2
index d399b593..76eaa672 100644
--- a/src/octoprint/plugins/pluginmanager/templates/pluginmanager_settings.jinja2
+++ b/src/octoprint/plugins/pluginmanager/templates/pluginmanager_settings.jinja2
@@ -45,7 +45,7 @@
             <div data-bind="css: {muted: !enabled}"><span data-bind="text: name"></span> <span data-bind="visible: version">(<span data-bind="text: version"></span>)</span> <i title="{{ _('Bundled') }}" class="icon-th-large" data-bind="visible: bundled"></i> <i title="Restart needed" class="icon-refresh" data-bind="visible: pending_enable || pending_disable || pending_uninstall"></i> <i title="Uninstalled" class="icon-remove" data-bind="visible: pending_uninstall"></i></div>
             <div><small class="muted" data-bind="text: description">&nbsp;</small></div>
             <div data-bind="css: {muted: !enabled}">
-                <small data-bind="visible: url"><i class="icon-home"></i> <a data-bind="attr: {href: url}">{{ _('Homepage') }}</a></small>
+                <small data-bind="visible: url"><i class="icon-home"></i> <a data-bind="attr: {href: url}" target="_blank" rel="noreferrer noopener">{{ _('Homepage') }}</a></small>
                 <small data-bind="visible: license"><i class="icon-legal"></i> <span data-bind="text: license"></span></small>
                 <small data-bind="visible: author"><i class="icon-user"></i> <span data-bind="text: author"></span></small>
                 <small>&nbsp;</small>
diff --git a/src/octoprint/plugins/softwareupdate/templates/softwareupdate.jinja2 b/src/octoprint/plugins/softwareupdate/templates/softwareupdate.jinja2
index 2cdae112..3e1b06be 100644
--- a/src/octoprint/plugins/softwareupdate/templates/softwareupdate.jinja2
+++ b/src/octoprint/plugins/softwareupdate/templates/softwareupdate.jinja2
@@ -11,7 +11,7 @@
             <!-- ko foreach: availableAndPossible -->
             <li>
                 <span class="name" data-bind="text: fullNameRemote, attr: {title: fullNameRemote}"></span>
-                <div class="releaseNotes" data-bind="visible: releaseNotes"><a data-bind="attr: {href: releaseNotes}">{{ _('Release Notes') }}</a></div>
+                <div class="releaseNotes" data-bind="visible: releaseNotes"><a data-bind="attr: {href: releaseNotes}" target="_blank" rel="noreferrer noopener">{{ _('Release Notes') }}</a></div>
             </li>
             <!-- /ko -->
         </ul>
diff --git a/src/octoprint/plugins/softwareupdate/templates/softwareupdate_settings.jinja2 b/src/octoprint/plugins/softwareupdate/templates/softwareupdate_settings.jinja2
index a148b20b..251c1e86 100644
--- a/src/octoprint/plugins/softwareupdate/templates/softwareupdate_settings.jinja2
+++ b/src/octoprint/plugins/softwareupdate/templates/softwareupdate_settings.jinja2
@@ -33,7 +33,7 @@
             <small class="muted">
                 {{ _('Installed:') }} <span data-bind="text: information.local.name"></span><br>
                 {{ _('Available:') }} <span data-bind="text: information.remote.name"></span><br>
-                <span data-bind="visible: releaseNotes">{{ _('Release Notes:') }} <a data-bind="attr: {href: releaseNotes}, text: releaseNotes" target="_blank"></a></span>
+                <span data-bind="visible: releaseNotes">{{ _('Release Notes:') }} <a data-bind="attr: {href: releaseNotes}, text: releaseNotes" target="_blank" rel="noreferrer noopener"></a></span>
             </small>
         </td>
     </tr>
diff --git a/src/octoprint/templates/index.jinja2 b/src/octoprint/templates/index.jinja2
index f661aa17..9659de66 100644
--- a/src/octoprint/templates/index.jinja2
+++ b/src/octoprint/templates/index.jinja2
@@ -115,10 +115,10 @@
                         <li><small>{{ _('Version') }}: <span class="version">{{ display_version|e }}</span></small></li>
                     </ul>
                     <ul class="pull-right">
-                        <li><a href="http://octoprint.org"><i class="icon-home"></i> {{ _('Homepage') }}</a></li>
-                        <li><a href="https://github.com/foosel/OctoPrint/"><i class="icon-github"></i> {{ _('Sourcecode') }}</a></li>
-                        <li><a href="http://docs.octoprint.org"><i class="icon-book"></i> {{ _('Documentation') }}</a></li>
-                        <li><a href="https://github.com/foosel/OctoPrint/issues"><i class="icon-flag"></i> {{ _('Bugs and Requests') }}</a></li>
+                        <li><a href="http://octoprint.org" target="_blank" rel="noreferrer noopener"><i class="icon-home"></i> {{ _('Homepage') }}</a></li>
+                        <li><a href="https://github.com/foosel/OctoPrint/" target="_blank" rel="noreferrer noopener"><i class="icon-github"></i> {{ _('Sourcecode') }}</a></li>
+                        <li><a href="http://docs.octoprint.org" target="_blank" rel="noreferrer noopener"><i class="icon-book"></i> {{ _('Documentation') }}</a></li>
+                        <li><a href="https://github.com/foosel/OctoPrint/issues" target="_blank" rel="noreferrer noopener"><i class="icon-flag"></i> {{ _('Bugs and Requests') }}</a></li>
                         <li id="footer_about"><a href="javascript:void(0)" data-bind="click: show"><i class="icon-info-sign"></i> {{ _('About') }}</a></li>
                     </ul>
                 </div>