From 6c21ee32a8f5febb32276857ca62cba004d3edb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gina=20H=C3=A4u=C3=9Fge?= Date: Wed, 5 Oct 2016 19:52:28 +0200 Subject: [PATCH] Fix broken filtering on ItemListHelper Filter toggling didn't remove the specific filter but always the last item in the filter list. No, I don't know either why I didn't notice this earlier m( --- src/octoprint/static/js/app/helpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/octoprint/static/js/app/helpers.js b/src/octoprint/static/js/app/helpers.js index 82e5f343..6abb4197 100644 --- a/src/octoprint/static/js/app/helpers.js +++ b/src/octoprint/static/js/app/helpers.js @@ -228,7 +228,7 @@ function ItemListHelper(listType, supportedSorting, supportedFilters, defaultSor return; var filters = self.currentFilters(); - filters.pop(filter); + filters = _.without(filters, filter); self.currentFilters(filters); self._saveCurrentFiltersToLocalStorage();