From 8f144accf443d745f848239c70f41551261b12c3 Mon Sep 17 00:00:00 2001 From: Teja Date: Wed, 23 Sep 2015 11:45:23 +0200 Subject: [PATCH] added todo comments --- src/octoprint/plugins/svgtogcode/__init__.py | 2 +- src/octoprint/util/comm_acc.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/octoprint/plugins/svgtogcode/__init__.py b/src/octoprint/plugins/svgtogcode/__init__.py index 954aa226..41db0b16 100644 --- a/src/octoprint/plugins/svgtogcode/__init__.py +++ b/src/octoprint/plugins/svgtogcode/__init__.py @@ -344,7 +344,7 @@ class SvgToGcodePlugin(octoprint.plugin.SlicerPlugin, if not machinecode_path: path, _ = os.path.splitext(model_path) machinecode_path = path + ".gco" - + self._svgtogcode_logger.info("### Slicing %s to %s using profile stored at %s" % (model_path, machinecode_path, profile_path)) ## direct call diff --git a/src/octoprint/util/comm_acc.py b/src/octoprint/util/comm_acc.py index ad8d553f..b6f616be 100644 --- a/src/octoprint/util/comm_acc.py +++ b/src/octoprint/util/comm_acc.py @@ -885,6 +885,8 @@ class MachineCom(object): pathToGrblHex = cwd + "/../grbl/grbl.hex" import subprocess + # TODO check if avrdude is installed. + # TODO log in logfile as well, not only to the serial monitor (use self._logger.info()... ) params = ["avrdude", "-patmega328p", "-carduino", "-b" + str(self._baudrate), "-P" + str(self._port), "-D", "-Uflash:w:" + pathToGrblHex] returnCode = subprocess.call(params)