pingu_98/MrDraw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

minor cleanup on command history. removing unneeded var.

Browse source
This commit is contained in:
Chris Kosmakos 2014-02-23 19:02:00 -08:00
parent 036e0af960
commit b976461c29
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/octoprint/static/js/app/viewmodels/terminal.js
View file

@ -22,7 +22,6 @@ function TerminalViewModel(loginStateViewModel, settingsViewModel) {
self.filterRegex = undefined;
self.cmdHistory = [];
self.cmdHistoryCnt = 0;
self.cmdHistoryIdx = -1;
self.activeFilters = ko.observableArray([]);
@ -109,8 +108,8 @@ function TerminalViewModel(loginStateViewModel, settingsViewModel) {
contentType: "application/json; charset=UTF-8",
data: JSON.stringify({"command": command})
});
self.cmdHistory[self.cmdHistoryCnt++] = command
self.cmdHistoryIdx = self.cmdHistoryCnt
self.cmdHistory.push(command);
self.cmdHistoryIdx = self.cmdHistory.length;
self.command("");
}
}
@ -119,11 +118,11 @@ function TerminalViewModel(loginStateViewModel, settingsViewModel) {
if (event.keyCode == 13) {
self.sendCommand();
} else if (event.keyCode == 38) {
if (self.cmdHistoryIdx >= 0) {
if (self.cmdHistory.length >= 0 && self.cmdHistoryIdx >= 0) {
self.command(self.cmdHistory[--self.cmdHistoryIdx])
}
} else if (event.keyCode == 40) {
if (self.cmdHistoryIdx < self.cmdHistoryCnt) {
if (self.cmdHistoryIdx < self.cmdHistory.length) {
self.command(self.cmdHistory[++self.cmdHistoryIdx])
}
}