pingu_98/MrDraw
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge branch 'rc/maintenance' into staging/maintenance

Browse source
This commit is contained in:
Gina Häußge 2017-05-24 12:33:40 +02:00
commit bd1d0e6073
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/octoprint/plugin/types.py
View file

@ -1377,6 +1377,14 @@ class SettingsPlugin(OctoPrintPlugin):
Of course, you are always free to completely override both :func:`on_settings_load` and :func:`on_settings_save` if the
default implementations do not fit your requirements.
.. warning::
Make sure to protect sensitive information stored by your plugin that only logged in administrators (or users)
should have access to via :meth:`~octoprint.plugin.SettingsPlugin.get_settings_restricted_paths`. OctoPrint will
return its settings on the REST API even to anonymous clients, but will filter out fields it know are restricted,
therefore you **must** make sure that you specify sensitive information accordingly to limit access as required!
.. attribute:: _settings
The :class:`~octoprint.plugin.PluginSettings` instance to use for accessing the plugin's settings. Injected by
@ -1548,8 +1556,8 @@ class SettingsPlugin(OctoPrintPlugin):
field="field"),
path=dict(to=dict(never=dict(return="return"))))
def get_settings_restricted_path(self):
return dict(admin=[["some", "admin_only", "path"], ["another", "admin_only", "path"],
def get_settings_restricted_paths(self):
return dict(admin=[["some", "admin_only", "path"], ["another", "admin_only", "path"],],
user=[["some", "user_only", "path"],],
never=[["path", "to", "never", "return"],])