diff --git a/src/octoprint/static/js/app/viewmodels/settings.js b/src/octoprint/static/js/app/viewmodels/settings.js index 7f558eeb..57b4487a 100644 --- a/src/octoprint/static/js/app/viewmodels/settings.js +++ b/src/octoprint/static/js/app/viewmodels/settings.js @@ -672,7 +672,7 @@ $(function() { additionalBaudrates: function() { return _.map(splitTextToArray(self.serial_additionalBaudrates(), ",", true, function(item) { return !isNaN(parseInt(item)); }), function(item) { return parseInt(item); }) }, longRunningCommands: function() { return splitTextToArray(self.serial_longRunningCommands(), ",", true) }, checksumRequiringCommands: function() { return splitTextToArray(self.serial_checksumRequiringCommands(), ",", true) }, - autoUppercaseBlacklist: function() { return splitTextToArray(self.serial_autoUppercaseBlacklist(), ",", true) }, + autoUppercaseBlacklist: function() { return splitTextToArray(self.serial_autoUppercaseBlacklist(), ",", true) } }, scripts: { gcode: function() { diff --git a/src/octoprint/static/js/app/viewmodels/terminal.js b/src/octoprint/static/js/app/viewmodels/terminal.js index 2ac68123..0f0aec86 100644 --- a/src/octoprint/static/js/app/viewmodels/terminal.js +++ b/src/octoprint/static/js/app/viewmodels/terminal.js @@ -124,6 +124,11 @@ $(function() { self.updateFilterRegex(); }); + self.blacklist=[]; + self.settings.serial_autoUppercaseBlacklist.subscribe(function(newValue) { + self.blacklist = splitTextToArray(newValue, ",", true); + }); + self._reenableFancyTimer = undefined; self._reenableUnfancyTimer = undefined; self._disableFancy = function(difference) { @@ -308,7 +313,6 @@ $(function() { var re = /^([gmt][0-9]+)(\s.*)?/; var commandMatch = command.match(re); - self.blacklist = splitTextToArray(self.settings.serial_autoUppercaseBlacklist(), ",", true); if (commandMatch != null) { command = commandMatch[1].toUpperCase() + ((commandMatch[2] !== undefined) ? commandMatch[2] : ""); if (self.blacklist.indexOf(commandMatch[1].toUpperCase()) < 0){ diff --git a/src/octoprint/templates/dialogs/settings/serialconnection.jinja2 b/src/octoprint/templates/dialogs/settings/serialconnection.jinja2 index b49e4670..86463c83 100644 --- a/src/octoprint/templates/dialogs/settings/serialconnection.jinja2 +++ b/src/octoprint/templates/dialogs/settings/serialconnection.jinja2 @@ -145,7 +145,7 @@
- {{ _('Use this to specify the commands that should not be automatically uppercased') }} + {{ _('Use this to specify the commands that should not be automatically uppercased. Comma seperated list.') }}
diff --git a/src/octoprint/util/comm.py b/src/octoprint/util/comm.py index 2b8edea0..9a571bda 100644 --- a/src/octoprint/util/comm.py +++ b/src/octoprint/util/comm.py @@ -420,7 +420,6 @@ class MachineCom(object): self._long_running_commands = settings().get(["serial", "longRunningCommands"]) self._checksum_requiring_commands = settings().get(["serial", "checksumRequiringCommands"]) - self._auto_uppercase_blacklist = settings().get(["serial", "autoUppercaseBlacklist"]) self._clear_to_send = CountedEvent(max=10, name="comm.clear_to_send") self._send_queue = SendQueue()