From ec55890c55a74bff65d4ebede611c0ed4bb1c4a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gina=20H=C3=A4u=C3=9Fge?= Date: Fri, 28 Jul 2017 12:01:36 +0200 Subject: [PATCH] Check that .metadata.yaml actually contains a dict It might just be empty (= None) or a list or something. Thanks @Kunsi for the heads-up. --- src/octoprint/filemanager/storage.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/octoprint/filemanager/storage.py b/src/octoprint/filemanager/storage.py index 0f49ec88..582abaea 100644 --- a/src/octoprint/filemanager/storage.py +++ b/src/octoprint/filemanager/storage.py @@ -1353,8 +1353,9 @@ class LocalFileStorage(StorageInterface): except: self._logger.exception("Error while reading .metadata.yaml from {path}".format(**locals())) else: - self._metadata_cache[path] = deepcopy(metadata) - return metadata + if isinstance(metadata, dict): + self._metadata_cache[path] = deepcopy(metadata) + return metadata return dict() def _save_metadata(self, path, metadata):