Commit graph

2503 commits

Author SHA1 Message Date
Gina Häußge
53bfbf5acf Refactored things a bit to remove a bit of repetition 2017-05-17 17:47:21 +02:00
Goswin von Brederlow
917c9e54ba Allow octoprint.comm.protocol.gcode.queuing hook to return a list of commands 2017-05-17 17:46:58 +02:00
Gina Häußge
9fac314d71 SWU: restart asynchronously instead of synchronously
Otherwise we will block ourselves, waiting for the restart command to
complete which it only can when we are no longer there.

Should reduce restart times on update significantly.

Downside is that we no longer can wait for the return code of the
call. However, that should be caught by our UI handler timing out for
the restart and showing an error prompting the user to restart
manually.
2017-05-17 13:44:11 +02:00
Gina Häußge
9dfee34f01 Fix various popup buttons allowing multiple clicks
As suggested by @ntoff in #1914
2017-05-17 13:44:08 +02:00
Gina Häußge
dc8473bc4d Add check for valid job file type to job validation 2017-05-17 13:44:04 +02:00
Ken
c1c75f032d Fixed webcam not loading bug if first/initial tab is "Control"
(cherry picked from commit d66a4f3)
2017-05-17 13:44:01 +02:00
Gina Häußge
9ad180c02a Disable "Upload to SD" ui elements while printing
As suggested by @ntoff in #1914
2017-05-17 13:43:57 +02:00
Gina Häußge
7795320fc8 Allow timelapse config through UI when not connected to printer
That restriction didn't really make sense.

As mentioned in #1918
2017-05-17 13:43:53 +02:00
Gina Häußge
51959319eb PGMR: Fix call to non existing onAlways
Closes #1919
2017-05-16 16:00:40 +02:00
Gina Häußge
6d73e6557b Timelapse: Disable "save as default" along other controls
Fixes #1918
2017-05-15 13:03:40 +02:00
Gina Häußge
4c65313c7f Fix a regression causing job data to be reset on completion of a print
Fixes #1917
2017-05-15 12:40:05 +02:00
Gina Häußge
3fbd477d15 Preparing release of 1.3.3rc1 2017-05-11 15:25:43 +02:00
Gina Häußge
2c73dd36c5 Final fixes before 1.3.3rc1 2017-05-11 15:23:45 +02:00
Gina Häußge
c91fe0c4fc Further decouple some plugin fetch tasks from initial startup thread 2017-05-11 15:23:41 +02:00
Gina Häußge
3bfc4725d2 SWU: Added cache timestamp to UI
Implements #1521
2017-05-11 12:45:02 +02:00
Gina Häußge
dba95ee94f Handle G90/G91 and M82/M83 distinct by default
By default G90/G91 define relativeMode, M82/M83 define relativeE. The
extruder coordinate will be viewed as relative when either
relativeMode or relativeE are set. This mirrors the implementation in
Marlin (current and legacy forks) as well as Repetier.

SmoothieWare's implementation resets the relative mode of the
extruder on a G90/G91. To still accomodate this different
implementation a new settings has been added under Settings >
Feature: "G90/G91 overrides relative extruder mode". Checking this
switches to the alternative interpretation for future gcode analysis
and visualization.

The only difference between the two of them is that the following
segment of GCODE:

    M83
    G90

will have the extruder still set to relative on Marlin and
Repetier but set to absolute on Smoothieware.

Please note that the setting in all likelihood will be moved to
the printer profile in the future, since it makes more sense to have
it on a per printer basis. It's not part of the set of features
available for auto detection since it's required for GCODE analysis
and hence needs to be known even outside of a connection to the
printer.

Implements #1818
2017-05-10 16:43:20 +02:00
Gina Häußge
f0b63a8e7f Set lines in log outputs to "display: block"
Taken from reverted commits 6465175e09
and 0f6edabea3.
2017-05-10 09:58:02 +02:00
Gina Häußge
e166765f7f Revert "Also use fastForEach in working dialogs of PMGR & software update"
This reverts commit 0f6edabea3.
2017-05-10 09:25:53 +02:00
Gina Häußge
15e8bbe147 Revert "Improve terminal performance by adding FastForEach"
This reverts commit 6465175e09.

# Conflicts:
#	src/octoprint/static/css/octoprint.css
#	src/octoprint/static/less/octoprint.less
2017-05-10 09:25:18 +02:00
Gina Häußge
853bb2fc16 Have G92 set pos directly, use offset only for tool offsets
See #1906 for related discussion
2017-05-09 17:17:08 +02:00
Gina Häußge
ccc3c4ef32 Detect invalid settings data to persist (not a dict), send 400 2017-05-09 14:36:45 +02:00
Gina Häußge
72898360f3 Get rid of ridiculous float precision in temperature commands
"M104 S200.00000000" is completely unnecessary when "M104 S200" works
just fine.
2017-05-09 09:38:10 +02:00
Gina Häußge
2caa10f15e Don't send T with temperature set commands for shared nozzles
Fixes #1907
2017-05-09 09:29:52 +02:00
Gina Häußge
399ec5a909 Allow configuring the webcam stream's aspect ratio
Options are 16:9 and 4:3, 16:9 is the default.
2017-05-08 17:35:51 +02:00
Gina Häußge
c844217f82 Placeholder for webcam image to avoid moving controls on load
An aspect ratio of 16:9 is assumed, with other ratios showing black
letterbox borders as required.

During loading a text "Webcam loading..." is displayed in the webcam
space. On loading error, the (broken) image is hidden and an error
text is displayed instead.

Solves #478
2017-05-08 17:04:03 +02:00
Gina Häußge
f32d7c434d Docs: Added note that coordinates in script context might be None
Wasn't made clear before.
2017-05-03 20:18:11 +02:00
Gina Häußge
844494a9d5 Only prevent command processing if streaming AND printing
Otherwise we might run into a rare race condition where the M110 sent
on start of a SD card upload gets prepared for sending after the
source file is already opened. That would then lead to the M110 not
getting processed anymore by OctoPrint and hence the line number
counter not resetting accordingly, leading to one line number
mismatch after the next from the firmware.

Testing if our "isPrinting" flag is ALSO set to true here ensures
that we'll only stop processing commands internally once the state
has actually switched to printing, which only happens after the
firmware responds to the M28 sent after the M110.

Fixes #1882 and probably also the issue encountered by @amd989 in
#1762 (which looks like exactly the same problem)
2017-05-03 18:55:00 +02:00
Gina Häußge
060aa1274a Some minor refactoring of #1898 for better maintainability 2017-05-02 17:45:28 +02:00
Andy Werner
fe0aa0301f Software update plugin: added check_type bitbucket_commit
(cherry picked from commit ee75ddc)
2017-05-02 17:25:01 +02:00
Gina Häußge
cda48f3b71 Fix some potential encoding issues
Might be a fix for #1884, can't be confirmed though, ticket is
incomplete.
2017-05-02 14:59:05 +02:00
Gina Häußge
c69ef1598a Don't allow multiple parallel webcam tests
Disable button when a test is already active. Also have spinner
defined centrally and only made visible on active test.

Should hopefully give better feedback to impatient users ;)

Solves #1897
2017-05-02 13:39:38 +02:00
Gina Häußge
0161d915d6 Some refactoring in CuraViewModel
* Use click data-bind for submit button instead of manual click
    binding
  * Keep metadata synchronized (otherwise changing identifier, name,
    description, overwrite or default flag after adding a file does
    absolutely nothing)
  * Disable submit button and fields when no file is selected.
  * Disable submit button (and show spinned) when request is in
    progress.

Related to #1893
2017-05-02 12:57:32 +02:00
Eyal Soha
f5fad5186e Clear upload data when Aborting cura profile upload modal.
This fixes #1893.

Also, only bind click to the "Confirm" button once instead of binding
and unbinding it for each file.  Binding it just once seems cleaner.

(cherry picked from commit 83d1921)
2017-05-02 10:04:54 +02:00
Gina Häußge
2817979c3d CSS updated 2017-05-02 09:57:26 +02:00
Gina Häußge
cc44c1a981 Make sure to properly handle unicode passwords
Fix & test for #1891
2017-05-02 09:35:02 +02:00
Gina Häußge
dda3a303d2 Recover terminal functionality on processing speed increase
If double the speed needed for output during print/fancy terminal
functionality is detected, re-enable that after a timeout of 5s.
Decrease of speed cancels the timeout again. That should prevent wild
toggling.

Should solve #1862
2017-04-20 12:15:40 +02:00
Gina Häußge
b79606da70 Never auto-complete GCODE to send
Solves #1875
2017-04-19 18:03:44 +02:00
Gina Häußge
fb9131f67a Some de-duplication 2017-04-19 11:34:34 +02:00
Eyal Soha
358a252736 Fix dragndrop upload
See #1867. Fixes #202.

(cherry picked from commit d658c64)
2017-04-19 11:34:11 +02:00
Gina Häußge
fd7c81c7fb Link to FAQ entry about SerialExceptions to log output
As suggested in #1876
2017-04-18 13:03:17 +02:00
Gina Häußge
2a7cebfe55 Keep "Load and print" button enabled when file is selected
Some users get confused by having to use the blue "Print" button in
the state panel for consecutive prints of the same model, let's solve
this once and for all.
2017-04-12 19:04:45 +02:00
Gina Häußge
0f6edabea3 Also use fastForEach in working dialogs of PMGR & software update 2017-04-12 18:54:08 +02:00
Gina Häußge
45231ea7f8 Merge branch 'improve/terminalFastForEach' into maintenance 2017-04-12 18:21:52 +02:00
Gina Häußge
c00b46ef5c Support timeout parameter in client and CLI 2017-04-12 15:40:54 +02:00
Gina Häußge
251a1ea4b5 "a couple" => "a few"/"some"
Because apparently I was using it wrong, at least for some parts of the
world :)
2017-04-12 14:54:32 +02:00
Gina Häußge
bba9d6cc18 Use proper timeouts for requests + better error handling
Default behaviour apparently is blocking, we never want that!

Also make error responses actually raise an exception.
2017-04-12 13:50:52 +02:00
BillyBlaze
6465175e09 Improve terminal performance by adding FastForEach
Move the AutoScroll function to an animation frame to prevent layout thrashing and to keep it in sync with fastForEach
Remove the <br> tag from the terminal and use display: block; on span tags to prevent increasing DOM nodes and faster processing of the terminal
2017-04-12 08:17:34 +00:00
Gina Häußge
fe585e7115 Do not repeatedly apply any set offsets in the gcode interpreter
They would accumulate and cause wrong calculations

Solves #1863
2017-04-12 09:38:53 +02:00
Gina Häußge
ef01560199 If file hash doesn't match on adding a file, kill all metadata 2017-04-10 17:31:00 +02:00
Gina Häußge
1666a1f607 Removed "minify" option for assets and some redundancy 2017-04-10 16:28:04 +02:00