pingu_98/cara
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

More concise/clearer way to compute the deltaT in air_exchange for WindowOpening; adding comments

Browse source
This commit is contained in:
Nicolas Mounet 2020-11-12 12:06:33 +01:00
parent 439c9fee07
commit 1ec9a0e9b0
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
cara/models.py
View file

@ -217,15 +217,17 @@ class WindowOpening(Ventilation):
if not self.active.triggered(time):
return 0.
# Reminder, no dependence on time in the resulting calculation.
inside_temp = self.inside_temp.value(time)
outside_temp = self.outside_temp.value(time)
# Reminder, no dependence on time in the resulting calculation.
if outside_temp < (inside_temp-self.min_deltaT):
temp_delta = (inside_temp - outside_temp) / outside_temp
else:
temp_delta = self.min_deltaT / outside_temp
root = np.sqrt(9.81 * self.window_height * temp_delta)
# The inside_temperature is forced to be always at least min_deltaT degree
# warmer than the outside_temperature. Further research needed to
# handle the buoyancy driven ventilation when the temperature gradient
# is inverted.
inside_temp = max(inside_temp, outside_temp + self.min_deltaT)
temp_gradient = (inside_temp - outside_temp) / outside_temp
root = np.sqrt(9.81 * self.window_height * temp_gradient)
window_area = self.window_height * self.opening_length * self.number_of_windows
return (3600 / (3 * room.volume)) * self.cd_b * window_area * root