From 2b3b567a31c91b4dc29e2d363721c4ddde1923aa Mon Sep 17 00:00:00 2001 From: lrdossan Date: Tue, 27 Aug 2024 10:25:21 +0200 Subject: [PATCH] renamed "find_change_points_with_scipy" to "find_change_points" for maintainability --- caimira/apps/calculator/co2_model_generator.py | 2 +- caimira/apps/calculator/co2_report_generator.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/caimira/apps/calculator/co2_model_generator.py b/caimira/apps/calculator/co2_model_generator.py index d9cfd78a..e4c20318 100644 --- a/caimira/apps/calculator/co2_model_generator.py +++ b/caimira/apps/calculator/co2_model_generator.py @@ -98,7 +98,7 @@ class CO2FormData(FormData): if not re.compile("^(2[0-3]|[01]?[0-9]):([0-5]?[0-9])$").match(time): raise TypeError(f'Wrong time format - "HH:MM". Got "{time}".') - def find_change_points_with_scipy(self) -> list: + def find_change_points(self) -> list: """ Perform change point detection using scipy library (find_peaks method) with rolling average of data. Incorporate existing state change candidates and adjust the result accordingly. diff --git a/caimira/apps/calculator/co2_report_generator.py b/caimira/apps/calculator/co2_report_generator.py index 4ef096ac..bb705a34 100644 --- a/caimira/apps/calculator/co2_report_generator.py +++ b/caimira/apps/calculator/co2_report_generator.py @@ -25,7 +25,7 @@ class CO2ReportGenerator: elif isinstance(CO2model.number, IntPiecewiseConstant): occupancy_transition_times = list(CO2model.number.transition_times) - ventilation_transition_times: list = form.find_change_points_with_scipy() + ventilation_transition_times: list = form.find_change_points() # The entire ventilation changes consider the initial and final occupancy state change all_vent_transition_times: list = sorted( [occupancy_transition_times[0]] +