From d1f22a03a790ebff4a8ca0f8010af56727ae114e Mon Sep 17 00:00:00 2001
From: Phil Elson <philip.elson@cern.ch>
Date: Mon, 3 May 2021 13:35:11 +0200
Subject: [PATCH] Re-instate all error handling details from #117.

---
 cara/apps/calculator/__init__.py          |  3 +++
 cara/tests/apps/calculator/test_webapp.py | 28 +++++++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/cara/apps/calculator/__init__.py b/cara/apps/calculator/__init__.py
index 12c8a624..5d6574b5 100644
--- a/cara/apps/calculator/__init__.py
+++ b/cara/apps/calculator/__init__.py
@@ -63,6 +63,7 @@ class BaseRequestHandler(RequestHandler):
             print(traceback.format_exc())
         self.finish(template.render(
             user=self.current_user,
+            active_page='Error',
             contents=contents
         ))
 
@@ -75,6 +76,7 @@ class Missing404Handler(BaseRequestHandler):
             "page.html.j2")
         self.finish(template.render(
             user=self.current_user,
+            active_page='Error',
             contents='Unfortunately the page you were looking for does not exist.<br><br><br><br>'
         ))
 
@@ -182,6 +184,7 @@ def make_app(
     loader = jinja2.FileSystemLoader([str(path) for path in templates_directories])
     template_environment = jinja2.Environment(
         loader=loader,
+        undefined=jinja2.StrictUndefined,  # fail when rendering any undefined template context variable
     )
 
     template_environment.globals['common_text'] = markdown_tools.extract_rendered_markdown_blocks(
diff --git a/cara/tests/apps/calculator/test_webapp.py b/cara/tests/apps/calculator/test_webapp.py
index 3c133684..ca7a893a 100644
--- a/cara/tests/apps/calculator/test_webapp.py
+++ b/cara/tests/apps/calculator/test_webapp.py
@@ -31,6 +31,17 @@ async def test_user_guide(http_server_client):
     assert resp.code == 200
 
 
+@pytest.mark.xfail(reason="about page not yet implemented")
+async def test_about(http_server_client):
+    resp = await http_server_client.fetch('/about')
+    assert resp.code == 200
+
+
+async def test_404(http_server_client):
+    resp = await http_server_client.fetch('/doesnt-exist', raise_error=False)
+    assert resp.code == 404
+
+
 class TestBasicApp(tornado.testing.AsyncHTTPTestCase):
     def get_app(self):
         return cara.apps.calculator.make_app()
@@ -83,3 +94,20 @@ async def test_invalid_compressed_url(http_server_client, baseline_form):
         raise_error=False,
     )
     assert response.code == 400
+
+
+class TestError500(tornado.testing.AsyncHTTPTestCase):
+    def get_app(self):
+        class ProcessingErrorPage(cara.apps.calculator.BaseRequestHandler):
+            def get(self):
+                raise ValueError('some unexpected error')
+        app = cara.apps.calculator.make_app()
+        page = [
+            (r'/', ProcessingErrorPage),
+        ]
+        return tornado.web.Application(page, **app.settings)
+
+    def test_500(self):
+        response = self.fetch('/')
+        assert response.code == 500
+        assert 'Unfortunately an error occurred when processing your request' in response.body.decode()