pingu_98/cara
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Raising an error if window_width is not specified in HingedWindow; using np.rad2deg instead of manual rad to degrees conversion

Browse source
This commit is contained in:
Nicolas Mounet 2020-12-02 18:58:55 +01:00
parent db25fa9768
commit e48d5c1900
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cara/models.py
View file

@ -260,6 +260,10 @@ class HingedWindow(WindowOpening):
#: Window width (m).
window_width: float = None
def __post_init__(self):
if self.window_width is None:
raise ValueError('window_width must be set')
@property
def discharge_coefficient(self) -> float:
"""
@ -284,7 +288,7 @@ class HingedWindow(WindowOpening):
else:
M = 0.038
cd_max = 0.548
window_angle = 2.*np.arcsin(self.opening_length/(2.*self.window_height))*180/np.pi
window_angle = 2.*np.rad2deg(np.arcsin(self.opening_length/(2.*self.window_height)))
return cd_max*(1-np.exp(-M*window_angle))