From ee98b1d30845b2f28e64d5d5950cd3f811e7dfe0 Mon Sep 17 00:00:00 2001
From: Luis Aleixo <luis.aleixo@cern.ch>
Date: Thu, 14 Mar 2024 16:20:01 +0100
Subject: [PATCH] added breathing cycle to short range dilution factor

---
 caimira/models.py              | 7 +++++--
 caimira/store/data_registry.py | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/caimira/models.py b/caimira/models.py
index b06c9d9b..e671194b 100644
--- a/caimira/models.py
+++ b/caimira/models.py
@@ -1355,8 +1355,11 @@ class ShortRangeModel:
         # Initial velocity of the exhalation airflow (m/s)
         u0 = np.array(Q_exh/Am)
 
-        # Duration of the expiration period(s), assuming a 4s breath-cycle
-        tstar: float = _dilution_factor['tstar'] # type: ignore
+        # Duration of one breathing cycle
+        breathing_cicle: float = _dilution_factor['breathing_cycle'] # type: ignore
+
+        # Duration of the expiration period(s)
+        tstar: float = breathing_cicle / 2
 
         # Streamwise and radial penetration coefficients
         _df_pc = _dilution_factor['penetration_coefficients'] # type: ignore
diff --git a/caimira/store/data_registry.py b/caimira/store/data_registry.py
index 429644ae..498db95b 100644
--- a/caimira/store/data_registry.py
+++ b/caimira/store/data_registry.py
@@ -363,7 +363,7 @@ class DataRegistry:
         "dilution_factor": {
             "mouth_diameter": 0.02,
             "exhalation_coefficient": 2,
-            "tstar": 2,
+            "breathing_cycle": 4,
             "penetration_coefficients": {
                 "𝛽r1": 0.18,
                 "𝛽r2": 0.2,