From a1034a4ca37c9f417dcae2a553b7aec9561a0f90 Mon Sep 17 00:00:00 2001 From: Sine Jespersen Date: Fri, 13 Jun 2025 11:33:24 +0200 Subject: [PATCH 01/16] correct classname to inputclassname as prop is named this --- src/lib/components/AddConnectionModal.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index f998cced0..ba46cd275 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -308,7 +308,7 @@
Date: Fri, 13 Jun 2025 11:56:36 +0200 Subject: [PATCH 02/16] add label to toggle connection button in configure connect modal --- src/lib/components/AddConnectionModal.svelte | 5 ++++- src/lib/components/common/Switch.svelte | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index ba46cd275..53422f87a 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -296,8 +296,11 @@
+ - +
diff --git a/src/lib/components/common/Switch.svelte b/src/lib/components/common/Switch.svelte index d19b160f4..0923e64f5 100644 --- a/src/lib/components/common/Switch.svelte +++ b/src/lib/components/common/Switch.svelte @@ -2,6 +2,7 @@ import { createEventDispatcher, tick } from 'svelte'; import { Switch } from 'bits-ui'; export let state = true; + export let id = ''; const dispatch = createEventDispatcher(); @@ -10,6 +11,7 @@ Date: Fri, 13 Jun 2025 11:58:36 +0200 Subject: [PATCH 03/16] add label to verify connection button --- src/lib/components/AddConnectionModal.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index 53422f87a..75fe37c81 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -279,6 +279,7 @@ verifyHandler(); }} type="button" + aria-label={$i18n.t('Verify Connection')} > Date: Fri, 13 Jun 2025 11:58:58 +0200 Subject: [PATCH 04/16] add aria hidden to decorative svg --- src/lib/components/AddConnectionModal.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index 75fe37c81..09ed0339f 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -285,6 +285,7 @@ xmlns="http://www.w3.org/2000/svg" viewBox="0 0 20 20" fill="currentColor" + aria-hidden="true" class="w-4 h-4" > Date: Fri, 13 Jun 2025 12:00:06 +0200 Subject: [PATCH 05/16] change label for url to label instead of div --- src/lib/components/AddConnectionModal.svelte | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index 09ed0339f..dd1d84561 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -258,10 +258,11 @@
-
{$i18n.t('URL')}
+
Date: Fri, 13 Jun 2025 13:16:11 +0200 Subject: [PATCH 06/16] highContrastMode (for accessibility) on text color in add connection modal --- src/lib/components/AddConnectionModal.svelte | 54 ++++++++++++++++---- 1 file changed, 45 insertions(+), 9 deletions(-) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index dd1d84561..b65f0ef8e 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -3,7 +3,7 @@ import { getContext, onMount } from 'svelte'; const i18n = getContext('i18n'); - import { models } from '$lib/stores'; + import { settings } from '$lib/stores'; import { verifyOpenAIConnection } from '$lib/apis/openai'; import { verifyOllamaConnection } from '$lib/apis/ollama'; @@ -258,7 +258,12 @@
- +
-
{$i18n.t('Key')}
+
-
{$i18n.t('Prefix ID')}
+
-
{$i18n.t('API Version')}
+
-
{$i18n.t('Tags')}
+
+ {$i18n.t('Tags')} +
-
{$i18n.t('Model IDs')}
+
+ {$i18n.t('Model IDs')} +
{#if modelIds.length > 0} @@ -413,7 +444,10 @@ {/each}
{:else} -
+
{#if ollama} {$i18n.t('Leave empty to include all models from "{{url}}/api/tags" endpoint', { url: url @@ -438,7 +472,9 @@ From 85018dd1069c91ef75fb0be92802c9d9b4734e26 Mon Sep 17 00:00:00 2001 From: Sine Jespersen Date: Fri, 13 Jun 2025 13:44:05 +0200 Subject: [PATCH 07/16] high contrast mode on placeholder --- src/lib/components/AddConnectionModal.svelte | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index b65f0ef8e..e49d060e3 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -268,7 +268,7 @@
- + {$i18n.t('Key')} +
Date: Fri, 13 Jun 2025 13:46:04 +0200 Subject: [PATCH 08/16] remove decorative svg from screen readers --- src/lib/components/icons/Plus.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/components/icons/Plus.svelte b/src/lib/components/icons/Plus.svelte index e5f3ba770..f2c5fb443 100644 --- a/src/lib/components/icons/Plus.svelte +++ b/src/lib/components/icons/Plus.svelte @@ -10,6 +10,7 @@ stroke-width={strokeWidth} stroke="currentColor" class={className} + aria-hidden="true" > From ba9e9e80957bca3ff92e5a639c7ae5ba4332ad39 Mon Sep 17 00:00:00 2001 From: Sine Jespersen Date: Fri, 13 Jun 2025 13:46:15 +0200 Subject: [PATCH 09/16] add aria label to button with no label --- src/lib/components/AddConnectionModal.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index e49d060e3..9d0d6f4fb 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -483,6 +483,7 @@
-
+ {/each} -
+ {:else}
Date: Fri, 13 Jun 2025 14:03:35 +0200 Subject: [PATCH 14/16] make taglist a list and add aria-labels --- src/lib/components/common/Tags.svelte | 4 ++-- src/lib/components/common/Tags/TagInput.svelte | 2 ++ src/lib/components/common/Tags/TagList.svelte | 7 +++++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/lib/components/common/Tags.svelte b/src/lib/components/common/Tags.svelte index 0f19eed9d..6c34b72de 100644 --- a/src/lib/components/common/Tags.svelte +++ b/src/lib/components/common/Tags.svelte @@ -9,7 +9,7 @@ export let tags = []; -
+
    { @@ -23,4 +23,4 @@ dispatch('add', e.detail); }} /> -
+ diff --git a/src/lib/components/common/Tags/TagInput.svelte b/src/lib/components/common/Tags/TagInput.svelte index a7a1a7891..b7e914803 100644 --- a/src/lib/components/common/Tags/TagInput.svelte +++ b/src/lib/components/common/Tags/TagInput.svelte @@ -29,6 +29,7 @@ bind:value={tagName} class=" px-2 cursor-pointer self-center text-xs h-fit bg-transparent outline-hidden line-clamp-1 w-[6.5rem]" placeholder={$i18n.t('Add a tag')} + aria-label={$i18n.t('Add a tag')} list="tagOptions" on:keydown={(event) => { if (event.key === 'Enter') { @@ -48,6 +49,7 @@ viewBox="0 0 16 16" fill="currentColor" stroke-width="2" + aria-hidden="true" class="w-3 h-3" > import { createEventDispatcher } from 'svelte'; + import { getContext } from 'svelte'; + const i18n = getContext('i18n'); import Tooltip from '../Tooltip.svelte'; import XMark from '$lib/components/icons/XMark.svelte'; import Badge from '../Badge.svelte'; @@ -10,7 +12,7 @@ {#each tags as tag} -
@@ -23,10 +25,11 @@ dispatch('delete', tag.name); }} type="button" + aria-label={$i18n.t('Remove this tag from list')} >
-
+
{/each} From 33a3aed698ce6543ca757c1c1c16199f5a1b4bc6 Mon Sep 17 00:00:00 2001 From: Sine Jespersen Date: Fri, 13 Jun 2025 14:42:55 +0200 Subject: [PATCH 15/16] remove repeated classes --- src/lib/components/AddConnectionModal.svelte | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/components/AddConnectionModal.svelte b/src/lib/components/AddConnectionModal.svelte index 990611f1f..e4f02e200 100644 --- a/src/lib/components/AddConnectionModal.svelte +++ b/src/lib/components/AddConnectionModal.svelte @@ -268,7 +268,7 @@
Date: Fri, 13 Jun 2025 14:43:03 +0200 Subject: [PATCH 16/16] hide decorative svg --- src/lib/components/common/Tags/TagInput.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/components/common/Tags/TagInput.svelte b/src/lib/components/common/Tags/TagInput.svelte index b7e914803..9d49fee4c 100644 --- a/src/lib/components/common/Tags/TagInput.svelte +++ b/src/lib/components/common/Tags/TagInput.svelte @@ -74,6 +74,7 @@