Commit graph

4663 commits

Author SHA1 Message Date
Gina Häußge
76c2113ad4 Fix block-level input-append/input-prepend
We still had double borders going on for included add-ons.
2017-08-22 18:05:00 +02:00
Gina Häußge
bfe5bc179c New hook octoprint.comm.protocol.temperatures.received
Allows preprocessing/sanitizing temperatures as received from the
printer.

Workaround for printers that occasionally report garbage temperature
data, e.g. #2050
2017-08-22 11:32:47 +02:00
Gina Häußge
d7298cee06 Virtual printer: Less code duplication in temp simulation 2017-08-22 11:21:04 +02:00
Gina Häußge
fbcbb3f5f7 Virtual printer: Support configurable ambient temperature 2017-08-21 16:52:38 +02:00
Gina Häußge
0c2169dd9c Removed leftover </span>
Thanks @dforsi for the heads-up.
2017-08-21 13:17:29 +02:00
Gina Häußge
7828258fdb Merge pull request #2048 from dforsi/fix/fix-rst
Fix some rst warnings
2017-08-21 12:38:20 +02:00
Daniele Forsi
edb4d0fe04 Fix warnings about duplicated names in rst files
Replacing a single underscore (which creates a named target) with a double
underscore creates an anonymous target.

Fixes:
/home/daniele/OctoPrint/docs/bundledplugins/cura.rst:4: WARNING: Duplicate explicit target name: "here".
/home/daniele/OctoPrint/docs/plugins/hooks.rst:370: WARNING: Invalid caption: /home/daniele/OctoPrint/docs/plugins/hooks.rst:4: (INFO/1) Duplicate explicit target name: "custom_action_command.py".
2017-07-30 23:18:08 +02:00
Gina Häußge
4d27de032d Improved handling of external reset while operational
* Display message to user
  * Stop print/transfer (lost state)
2017-07-28 13:35:00 +02:00
Gina Häußge
7073c12444 Virtual printer: Support debug commands while streaming 2017-07-28 13:34:10 +02:00
Gina Häußge
60be6349f5 Allow cancelling file transfers
Cancelling also deletes the incomplete file on the printer's SD.
2017-07-28 13:08:28 +02:00
Gina Häußge
ec55890c55 Check that .metadata.yaml actually contains a dict
It might just be empty (= None) or a list or something.

Thanks @Kunsi for the heads-up.
2017-07-28 12:01:36 +02:00
Gina Häußge
e508898564 Merge branch 'staging/maintenance' into maintenance 2017-07-27 14:38:54 +02:00
Gina Häußge
c33e9e4c85 staging is 1.3.5rc3.dev 2017-07-27 14:38:30 +02:00
Gina Häußge
1f9fe8c868 Preparing release of 1.3.5rc2 2017-07-27 13:33:45 +02:00
Gina Häußge
8f2e4ad978 Temperature tab: "Hotend" -> "Tool" 2017-07-27 12:41:08 +02:00
Gina Häußge
b82d955ec7 Fix printer profile update on temperature tab & gcode viewer
As reported in #2033
2017-07-27 12:40:27 +02:00
Gina Häußge
832d2f4155 Fix temperature controls in FF not fitting on one line
Mentioned in #2033
2017-07-27 10:14:59 +02:00
Gina Häußge
c336452f6c Do not run subprocesses while intermediary server is active
Any processes inheriting the open port descriptor of that server will
cause the actual server startup to fail due to the port still being
claimed.

We can't fully prevent this under Windows thanks to fnctl not being
available and win32api being a PITA, and also close_fds on Popen not
being allowed if we also need to redirect stdout/stderr/stdin for a
process. So let's hope hardening against this problem when running
under *nix, adding a bit fat warning to never start a subprocess
during the intermediary's runtime and also moving the only actual
process we so far DID start (analysis backlog processing) to after
Tornado is running will suffice.

Fixes #2035
2017-07-27 09:58:20 +02:00
Gina Häußge
a9b6edde2b Fix incompatibility with non-ASCII strings in wizard sorting 2017-07-26 16:47:57 +02:00
Gina Häußge
d59ef5c711 Corewizard: Fix wrongly displaying firstrunonly wizards again 2017-07-26 16:47:40 +02:00
Gina Häußge
375480c707 allViewModels -> self.allViewModels 2017-07-26 16:32:05 +02:00
Gina Häußge
60cacb9447 Temperature: Fix for legend not updating with current values
See #2033
2017-07-26 16:26:27 +02:00
Gina Häußge
a21f5c4497 Merge branch 'staging/maintenance' into maintenance 2017-07-26 14:27:59 +02:00
Gina Häußge
c159ab7fe2 Merge branch 'rc/maintenance' into staging/maintenance 2017-07-26 14:27:47 +02:00
Gina Häußge
251ed7a2a2 Merge branch 'staging/maintenance' into maintenance 2017-07-26 14:25:15 +02:00
Gina Häußge
e949e0198f maintenance is now 1.3.6.dev, staging is 1.3.5rc2.dev 2017-07-26 14:24:30 +02:00
Gina Häußge
1a6dbb3f4a Preparing release of 1.3.5rc1 2017-07-26 12:47:47 +02:00
Gina Häußge
10e834f623 Improve logging of async system commands
Closes #2025
2017-07-24 18:32:21 +02:00
Gina Häußge
5ce34f774e GCODE Viewer: Fix file position calculation
We were only adding one byte for "\n". That ignored that our regex
could also match "\r\n" or "\r\r" or something like that.

Our split regex now only matches one "\r" or "\n". Empty lines we'll
simply ignore anyhow so no real harm done.

Also, we no longer strip the comments in this step - leave that to
the worker running in its own thread. Not only should that speed
things up a bit, it will also allow us to better debug the worker in
the future.
2017-07-24 12:55:39 +02:00
Gina Häußge
0456896d71 GCODE Viewer: Fix issue with lookup of layer index 0
We were just testing if z_heights[z] was truthy. If the layer index was
set but 0 that wasn't properly detected and let to overwriting our
layer information. Instead check explicitly against undefined.

Closes #2017
2017-07-24 12:52:13 +02:00
Gina Häußge
e06c09e206 Fix some more FontAwesome related things
* remove some more "fa" classes where they didn't belong
  * use "fa-toggle-(on|off)" instead of circles where they were used
    to signify toggle actions
  * fix SD card icon being too high

Another follow-up to #1915
2017-07-21 12:29:18 +02:00
Gina Häußge
a6d3299b91 Add user manager factory hook 2017-07-20 20:03:05 +02:00
Gina Häußge
0a7f2a209b Add opt-in wizard for online connectivity check
See also #2011
2017-07-20 20:02:57 +02:00
Gina Häußge
67f7580506 Only run connectivity checker if enabled
Otherwise assume we are online but don't ping anything.

See also #2011
2017-07-20 20:02:44 +02:00
Gina Häußge
aab3a7bd63 Wizard: Support to prevent the "settings updated" dialog
Subwizards might actually intentionally want to update stuff through
the settings API, let's allow that.
2017-07-20 19:36:14 +02:00
Gina Häußge
d0f5592421 Fix sorting of filament usage for more than one tool 2017-07-20 19:23:52 +02:00
Gina Häußge
bb6ea4d81b Also set autocorrect to off on username field 2017-07-20 09:50:08 +02:00
Gina Häußge
7e32e5be8f GCODE viewer: Support \r, \n and \r\n line endings
So far we only supported \n and \r\n, leading to problems with MM
GCODE files generated by Slic3r Prusa Edition which apparently
produces \r line endings for some reason.

Closes #1996
2017-07-20 09:18:38 +02:00
Gina Häußge
266cae3509 PMGR: Refresh on any connectivity change 2017-07-19 18:49:52 +02:00
Gina Häußge
0dcbffb9d2 Bundled plugins: Handle connectivity states
See also #2011
2017-07-19 18:42:29 +02:00
Gina Häußge
fb8c56be57 SWU: Track network connectivity & handle offline scenarios
See also #2011
2017-07-19 18:42:28 +02:00
Gina Häußge
2bc0c4a77f Synchronize pip helper cache access 2017-07-19 18:42:28 +02:00
Gina Häußge
187c09e7da Centralized online connectivity check
See also #2011
2017-07-19 18:42:27 +02:00
Gina Häußge
5c62b33967 Do not call uninitialized plugins in call_plugin 2017-07-19 18:42:26 +02:00
Gina Häußge
5db9acb359 SWU: Fix CLI commands
Client refactoring in d72c7c14 caused issues here.

Closes #2012
2017-07-18 12:39:11 +02:00
Gina Häußge
962d6ab27f CLI: Helpers for initializing client from command line 2017-07-18 12:37:23 +02:00
Gina Häußge
21699699b6 CLI: Fixed logging init for plugins
Also fixed a stupid typo ;)
2017-07-18 12:36:16 +02:00
Gina Häußge
8fec0859d9 Don't use fixed width on terminal input
Instead added some additional styles to support input-block-level
inputs with add-ons.
2017-07-18 09:46:32 +02:00
Shawn Bruce
1b9ff1b0e2 Move terminal command below terminal output and fill the row
Clicking terminal output (excluding highlighting) will set focus to terminal command
Change fancy functionality style from muted to warning so that it stands out more
2017-07-17 12:42:14 -04:00
Gina Häußge
ee2d644239 Remove support for multi command expansion in sending phase
We won't support this after all, it's too much of a headache with
regards to the sending queue. Pausing takes longer, cancelling takes
longer, resends get more complicated and so on.

Command expansion in the queuing phase needs to suffice.
2017-07-17 16:26:32 +02:00